A partial archive of https://discourse-mediawiki.wmflabs.org as of Saturday May 21, 2022.

Outgoing reviews Verified +1 git-reviews

jehovahsays

I see that i have a list of Outgoing reviews that are Verified +1 git-reviews from jenkins bot. it appears that they have passed build tests but none of them are merged. Did i drop the ball and missed a last step to merge?

RazeSoldier

Requires Code-Review +2 label and Verified +2 label to merge a patch. See https://www.mediawiki.org/wiki/Gerrit/Code_review#Complete_the_review

RazeSoldier

This is a successful merged case: https://gerrit.wikimedia.org/r/#/c/395768/

jehovahsays

Thanks. That what i needed to read.

Tgr

Once you have been around for a while and a couple of your patches got merged, you can ask someone to add you to the CI whitelist so the bot will add Verified +2 instead of Verified +1. (The difference is that +2 involves some tests that can be abused by a malicious patch uploader.)

RazeSoldier

Can I join the CI whitelist in my situation?

Ciencia-Al-Poder

Well, I don’t see where one can ask to get added to the CI whitelist, so I’m going to also ask to get on that whitelist :wink:

Tgr

Unfortunately I had very little free time but I wrote some documentation on the whitelist to make this more of a self-service thing.

RazeSoldier

Thanks for you make time.

TheDJ

This made me wonder… can’t we make it so that +2 is granted automaticly after a few patches of an author have been merged ? A bit like autoconfirmed ?

Tgr

The grand plan is to make every build run in its own disposable container and get rid of the whitelist, but in the short term something like that would be nice, yeah.

RazeSoldier

For me, the CI whitelist like confirmed user group (confirm manually).