A partial archive of https://discourse-mediawiki.wmflabs.org as of Saturday May 21, 2022.

First push to Gerrit for review

JHunterHobbs

I recently made my first push to Gerrit for a patch review. I don’t see where the Jenkins-bot has even verified that it passed the acceptance tests. I wanted to make sure that I followed the workflow correctly and how to get it reviewed. Thanks.

Issue: T161612

https://gerrit.wikimedia.org/r/#/c/408577/

srishakatux

Hello! First of all, congrats and thank you for submitting your first patch! As you might have seen already, you have received some feedback on the patch. So the next step would be that you take the feedback into account, follow the coding conventions for Javascript, make necessary changes to your code following the instructions here: https://www.mediawiki.org/wiki/Gerrit/Tutorial#Amending_a_change_(your_own_or_someone_else’s).

Also, it looks like you removed jenkins-bot as a reviewer which you shouldn’t have done. Learn more here.

Tgr

Jenkins is a bit fragile right now. See T186381.

JHunterHobbs

I edited the patch per the amended guidelines but I think I did something that not exactly correct…

My first attempt at making the changes, I rebased my branch and then actually forgot to add/commit before I pushed for review (oops). I then actually added the adjustments and submitted for review but it says ‘uploaded patch set 3.’ - Should I strictly be on patch set 1 or is this okay? Any guidance is highly appreciated.

Thanks!

Tgr

The patchset number increases every time you amend the patch (upload a new patchset). It’s only there to track changes and make it possible to see which version of the patch a specific comment was addressing.

JHunterHobbs

Ok. Great. I understand this particular issue is a low priority bug, but what is the typical turnaround for getting patches reviewed? If they sit unattended for a while, is there an appropriate way to try to get the most current patch reviewed?

Thanks for all your help.

srishakatux

You might find the following resource around Getting reviews on MediaWiki useful https://www.mediawiki.org/wiki/Gerrit/Code_review/Getting_reviews. If your patch already has reviewers, but it goes unattended for a while, then you could bring this up in the IRC channel #wikimedia-dev.

Tgr

Adding some of the maintainers as reviewers can help; if it doesn’t, you can add your patch to the code review office hours.